Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable fingers crossed handler by default and add optional support in CLI mode #15624

Draft
wants to merge 4 commits into
base: 4.x-dev
Choose a base branch
from
Draft

Enable fingers crossed handler by default and add optional support in CLI mode #15624

wants to merge 4 commits into from

Conversation

diosmosis
Copy link
Member

Fixes #15220

@diosmosis diosmosis added the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Feb 26, 2020
@diosmosis diosmosis added this to the 4.0.0 milestone Feb 26, 2020
@diosmosis diosmosis added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Feb 26, 2020
@diosmosis
Copy link
Member Author

@mattab ran into blocking issue w/ DI that I can't figure out just yet, think it would be good to move out of 4.0.

@mattab
Copy link
Member

mattab commented Mar 2, 2020

What's the issue @diosmosis ? we can move this out if the issue can't be resolved.

@diosmosis
Copy link
Member Author

@mattab I couldn't add definitions to the climulti environment to add the fingers crossed handler. The file was always included in php-di and php-di saw the new definitions, but php-di never used them. It would take a while to debug unfortunately.

@mattab
Copy link
Member

mattab commented Mar 5, 2020

@tsteur maybe you have some thoughts on this?

@tsteur
Copy link
Member

tsteur commented Mar 5, 2020

@mattab best to just close the PR. I'm not seeing a big need for this feature anyway

@mattab
Copy link
Member

mattab commented Mar 11, 2020

Moved it out of 4.0.0 for now.

Btw the great value of this feature is that for example, when core:archive fails due to a SQL query error, then we can see in the core:archive error output the full SQL query that caused the error (for example a timeout). This is valuable in identifying the root cause of the core:archive error and quickly find a faq or solution to the problem (or reaching out to support with the query).

@mattab mattab removed this from the Priority Backlog (Help wanted) milestone Mar 11, 2020
@michalkleiner michalkleiner marked this pull request as draft March 13, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable fingers crossed handler by default for more useful debug logs
3 participants
@diosmosis @mattab @tsteur