@diosmosis opened this Pull Request on February 26th 2020 Member

Fixes #15220

@diosmosis commented on February 29th 2020 Member

@mattab ran into blocking issue w/ DI that I can't figure out just yet, think it would be good to move out of 4.0.

@mattab commented on March 2nd 2020 Member

What's the issue @diosmosis ? we can move this out if the issue can't be resolved.

@diosmosis commented on March 2nd 2020 Member

@mattab I couldn't add definitions to the climulti environment to add the fingers crossed handler. The file was always included in php-di and php-di saw the new definitions, but php-di never used them. It would take a while to debug unfortunately.

@mattab commented on March 5th 2020 Member

@tsteur maybe you have some thoughts on this?

@tsteur commented on March 5th 2020 Member

@mattab best to just close the PR. I'm not seeing a big need for this feature anyway

@mattab commented on March 11th 2020 Member

Moved it out of 4.0.0 for now.

Btw the great value of this feature is that for example, when core:archive fails due to a SQL query error, then we can see in the core:archive error output the full SQL query that caused the error (for example a timeout). This is valuable in identifying the root cause of the core:archive error and quickly find a faq or solution to the problem (or reaching out to support with the query).

Powered by GitHub Issue Mirror