Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention require PHP 7.2 in admin notification #15623

Closed
tsteur opened this issue Feb 25, 2020 · 2 comments · Fixed by #15670
Closed

Mention require PHP 7.2 in admin notification #15623

tsteur opened this issue Feb 25, 2020 · 2 comments · Fixed by #15670
Assignees
@sgiehl
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone
3.13.4

Comments

@tsteur
Copy link
Member

tsteur commented Feb 25, 2020

I think we haven't yet enabled this admin notification. The code should be already there but likely disabled. Basically, the goal is, if someone is using PHP 7.1 or older that they should upgrade to PHP 7.2 at least or better even directly PHP 7.4.
@tsteur tsteur added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Feb 25, 2020
@tsteur tsteur added this to the 3.13.4 milestone Feb 25, 2020
@sgiehl sgiehl self-assigned this Mar 5, 2020
@sgiehl sgiehl mentioned this issue Mar 5, 2020
Merged
@sgiehl sgiehl linked a pull request Mar 5, 2020 that will close this issue
activate warning for php versions incompatible with next major release #15670
Merged
@Findus23
Copy link
Member

Findus23 commented Mar 9, 2020

Weird that this didn't get closed.

@Findus23 Findus23 closed this as completed Mar 9, 2020
@sgiehl
Copy link
Member

sgiehl commented Mar 13, 2020

@Findus23 all issues merged into 3.x-dev aren't closed automatically as they are not in the "default" branch (which is currently 4.x-dev)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Milestone
3.13.4
Development

Successfully merging a pull request may close this issue.

activate warning for php versions incompatible with next major release matomo-org/matomo
3 participants
@tsteur @sgiehl @Findus23