Fix failing Live system test #15621
Merged
Fix failing Live system test #15621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
c: Tests & QA
|
Should be fine to merge @sgiehl good find 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Investigated why one System test of Live plugin is failing on
4.x-devbut not on3.x-dev. Looking back through the builds it turned out the reason actually is #14847, which changed thereferrer_urlcolumn fromTEXTtoVARCHAR(4000). I'm able to reproduce that locally. Changing back toTEXTfixes the test again.I guess that is a sorting issue in MySQL. Most attributes of the visits are identical, and the referrer urls are even empty. Not sure if there is anything we need to adjust. Might be fine to simply update the expected file.
ping @diosmosis @tsteur