Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specific countries appear in visit log but return no results when segmented #15620

Closed
tsteur opened this issue Feb 25, 2020 · 5 comments · Fixed by #18321
Closed

Specific countries appear in visit log but return no results when segmented #15620

tsteur opened this issue Feb 25, 2020 · 5 comments · Fixed by #18321
Assignees
@bx80
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone
4.7.0

Comments

@tsteur
Copy link
Member

tsteur commented Feb 25, 2020 •
edited

See eg https://demo.matomo.org/index.php?module=API&method=API.getSuggestedValuesForSegment&segmentName=countryName&idSite=62&format=JSON&token_auth=anonymous

We return the first 100 countries alphabetically instead of ideally checking which countries are actually visited sorted by the number of visits desc rather than alpabetically
@tsteur tsteur added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. labels Feb 25, 2020
@tsteur tsteur added this to the Priority Backlog (Help wanted) milestone Feb 25, 2020
@sgiehl
Copy link
Member

sgiehl commented Feb 25, 2020

Don't we have that case in multiple places? Everywhere where we have a fixed list of possible values. Like browser or os

@tsteur
Copy link
Member Author

tsteur commented Feb 25, 2020

yes 👍 as part of this should probably also look at some other cases that maybe return more than 100 results and are static

@tsteur tsteur mentioned this issue Mar 3, 2020
Open
@tsteur tsteur mentioned this issue Mar 31, 2020
Closed
@tsteur tsteur mentioned this issue Aug 19, 2020
Closed
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Aug 19, 2020
@tsteur tsteur mentioned this issue Dec 27, 2020
Closed
@tsteur
Copy link
Member Author

tsteur commented Jul 27, 2021

Let's change it for browsers, OS and countries for now and make the change later for others when they come up. We can also change any other obvious ones meaning we don't need to search for it and know that it needs to be changed there too.

This should be easily fixed by calling eg $segment->setSuggestedValuesApi('UserCountry.get...'); on the segment instead of configuring a hard coded list. It might be a problem though if short codes are needed instead of names.

@Starker3
Copy link
Contributor

Starker3 commented Oct 6, 2021

Do we have any ETA for this issue? It looks like it was added to the 4.3.0 milestone. We've had some users contact us regarding this issue.

@tsteur
Copy link
Member Author

tsteur commented Oct 6, 2021

It's in the 4.7.0 milestone. Possibly beginning next year I would say.

@bx80 bx80 self-assigned this Nov 16, 2021
@bx80 bx80 mentioned this issue Nov 16, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bx80 bx80

Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Milestone
4.7.0
Development

Successfully merging a pull request may close this issue.

Sort segment static lists by usage matomo-org/matomo
5 participants
@tsteur @mattab @sgiehl @Starker3 @bx80