Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent server gone away error in CronArchive #15619

Merged
merged 2 commits into from Feb 26, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Feb 24, 2020

What happens is basically eg some archive requests run for 6 hours, then it returns back into the CronArchive scripts, it tries to execute a query, and results in a server gone away error because the DB connection wasn't used for hours.

Fixes only when a CronArchive happens directly in CronArchive.php script. We've tested this in production for one month and worked nicely.

@tsteur tsteur added the Needs Review PRs that need a code review label Feb 24, 2020
@tsteur tsteur added this to the 4.0.0 milestone Feb 24, 2020
@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label Feb 24, 2020
core/CronArchive.php Outdated Show resolved Hide resolved
@tsteur
Copy link
Member Author

tsteur commented Feb 25, 2020

@sgiehl updated

@sgiehl sgiehl merged commit f2c0c90 into 4.x-dev Feb 26, 2020
@sgiehl sgiehl deleted the cronarchive_servergoneaway branch February 26, 2020 07:50
@mattab mattab added the c: Performance For when we could improve the performance / speed of Matomo. label Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Performance For when we could improve the performance / speed of Matomo. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants