@sgiehl opened this Pull Request on February 24th 2020 Member

fixes #9785

@sgiehl commented on March 24th 2020 Member

@tsteur @diosmosis could you maybe have a first look at the PR?
In general the changes should already work. But for sure will need some more excessive testing

What still needs to be clarified:

  • When updating to Matomo 4, or installing it newly then, it can still be the case that utf8 charset will be used, if utf8mb4 is not available. If that is the case, the update to utf8mb will be actually never tried again. Wondering if we should maybe try to do the conversion for every update automatically if utf8mb4 is not yet configured.

  • Using the database charset config to determine if the tables actually use utf8mb4 might not be very save. Someone could maybe change the charset even though the update wasn't performed. Not sure if we should handle that case and maybe store the used charset in the option table instead or maybe simply ignore that case, as it likely shouldn't happen often. Also saving the config in the update process might fail or not work on multi server env 🤔

  • I've changed the length of various fields, so the key length fits again. Imho the new length shouldn't make any problem, but be good if someone else have a thought about that as well...
Powered by GitHub Issue Mirror