Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure "Event Category" is translated in Visits log API outputs #15615

Merged
merged 2 commits into from Feb 24, 2020

Conversation

mattab
Copy link
Member

@mattab mattab commented Feb 24, 2020

eg. reproduced on any user that has visited events, eg. index.php?date=2020-02-24&module=API&action=index&visitorId=7a6948677b781fae&idSite=1&period=day&method=Live.getVisitorProfile&format=XML&expanded=1

outputs this:

<title>Event</title>
<subtitle>Event_Category: "Add review', Action: "click"</subtitle>

but we don't expect "Event_Category" in there. It is fixed here.

PS: some tests will need to be fixed

@mattab mattab added the Needs Review PRs that need a code review label Feb 24, 2020
@mattab mattab added this to the 4.0.0 milestone Feb 24, 2020
mattab and others added 2 commits February 24, 2020 10:12
eg. reproduced on http://localhost/matomo/index.php?date=2020-02-24&module=API&action=index&visitorId=7a6948677b781fae&idSite=1&period=day&method=Live.getVisitorProfile&format=XML&expanded=1&token_auth=fd96e87bf733a7e45d072fa714c1d0ae

which outputs:
```
<title>Event</title>
<subtitle>Event_Category: "Add review', Action: "click"</subtitle>
```

we don't expect "Event_Category" in there. which is fixed here
@sgiehl
Copy link
Member

sgiehl commented Feb 24, 2020

will update the test files and merge afterwards...

@sgiehl sgiehl merged commit 50e2acb into 4.x-dev Feb 24, 2020
@sgiehl sgiehl deleted the events_category branch February 24, 2020 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants