Fix session cookies for Matomo installed in subdirectory #15602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
Major
sgiehl
force-pushed
the
fixsessioncookie
branch
from
96f431c
to
4b7df98
Compare
sgiehl
force-pushed
the
fixsessioncookie
branch
from
4b7df98
to
862499c
Compare
tsteur
removed
the
Major
jonasgrilleres
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 22, 2020
jbuget
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sending the cookie path encoded seems to let the browser discard the path value as invalid and use the current path instead. This causes two session cookies, one with current path, one with
/. When logging out only of the cookies gets a new session id, the other one remains. That makes it impossible to login again until the cookies are cleared (or expire).