Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix VisitorFrequency.get API for idsites=all #15601

Merged
merged 1 commit into from Feb 21, 2020
Merged

Fix VisitorFrequency.get API for idsites=all #15601

merged 1 commit into from Feb 21, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Feb 20, 2020

The ArchiveCronTest was failing for a while now already. It actually seemed to be a regression from #15128

not sure if it's worth to cherry-pick it to 3.x as well (ping @mattab @tsteur )

@sgiehl sgiehl added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Feb 20, 2020
@sgiehl sgiehl added this to the 4.0.0 milestone Feb 20, 2020
@sgiehl sgiehl added the Needs Review PRs that need a code review label Feb 20, 2020
@tsteur
Copy link
Member

tsteur commented Feb 20, 2020

@sgiehl it be not worth it to cherry pick but if it makes the tests work on 3.x feel free to cherry pick

@sgiehl sgiehl merged commit b25fcee into 4.x-dev Feb 21, 2020
@sgiehl sgiehl deleted the fixfreqapi branch February 21, 2020 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis diosmosis left review comments

Assignees
No one assigned
Labels
Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sgiehl @tsteur @diosmosis