Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve / Fix UserID tests #15595

Merged
merged 2 commits into from Feb 19, 2020
Merged

Improve / Fix UserID tests #15595

merged 2 commits into from Feb 19, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Feb 19, 2020

For #15520 I investigated why the one action that should be tracked as a new visit, wasn't tracked as that. Turned out the problem is, that all visits before are tracked with ->setVisitorId(), but that one tries to set a ->randomVisitorId. That doesn't work as setVisitorId() sets a forced visitor id, which overrules the random one...

@sgiehl sgiehl added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Feb 19, 2020
@sgiehl sgiehl added this to the 4.0.0 milestone Feb 19, 2020
@sgiehl sgiehl merged commit 466bbb3 into 4.x-dev Feb 19, 2020
@sgiehl sgiehl deleted the improvetest branch February 19, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant