Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to determine the region iso code based on its name if not available #15592

Merged
merged 2 commits into from Feb 22, 2020
Merged

Try to determine the region iso code based on its name if not available #15592

merged 2 commits into from Feb 22, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Feb 19, 2020

refs #15589

@sgiehl sgiehl added the Needs Review PRs that need a code review label Feb 19, 2020
@sgiehl sgiehl added this to the 3.13.3 milestone Feb 19, 2020
@tsteur tsteur modified the milestones: 3.13.3, 3.13.4 Feb 19, 2020
@tsteur
Copy link
Member

tsteur commented Feb 19, 2020

Moving this into 3.13.4 for now. Be good to add a test @sgiehl

Could also move it into Matomo 4 if needed but 3.13.4 should be fine.

@sgiehl
Copy link
Member Author

sgiehl commented Feb 20, 2020

Will try to add one

@sgiehl
Copy link
Member Author

sgiehl commented Feb 20, 2020

done

@tsteur tsteur merged commit 9aff078 into 3.x-dev Feb 22, 2020
@tsteur tsteur deleted the determineregioniso branch February 22, 2020 01:05
@mattab mattab changed the title Try to determine the region iso code based on it's name if not available Try to determine the region iso code based on its name if not available Feb 24, 2020
@sgiehl sgiehl mentioned this pull request Mar 5, 2020
Closed
jonasgrilleres pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 22, 2020
@sgiehl @jonasgrilleres
Try to determine the region iso code based on it's name if not availa…
33169c0 
…ble (matomo-org#15592)

* Try to determine the region iso code based on it's name if not available

* Adds test for region without code
jbuget pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 26, 2020
@sgiehl @jbuget
Try to determine the region iso code based on it's name if not availa…
1c4cb55 
…ble (matomo-org#15592)

* Try to determine the region iso code based on it's name if not available

* Adds test for region without code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
3.13.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @tsteur