Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CSV export for idSite=all #15584

Merged
merged 3 commits into from Feb 26, 2020
Merged

Fix CSV export for idSite=all #15584

merged 3 commits into from Feb 26, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Feb 17, 2020

problem was actually not only the CSV exporter, but also some plugins did failing defining their report metadata when idSite=all

fixes #14362

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Feb 17, 2020
@sgiehl sgiehl added this to the 4.0.0 milestone Feb 17, 2020
@diosmosis
Copy link
Member

One other thing, can we add tests for this?

@sgiehl
Copy link
Member Author

sgiehl commented Feb 26, 2020

@diosmosis add a new test

@diosmosis diosmosis merged commit bcbdf42 into 4.x-dev Feb 26, 2020
@diosmosis diosmosis deleted the csvallexport branch February 26, 2020 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis diosmosis left review comments

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

csv export for VisitsSummary.getVisits with idSite=all and non-superuser not working
2 participants
@sgiehl @diosmosis