Fixes some comparison issues #15583
Merged
Fixes some comparison issues #15583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
not-in-changelog
sgiehl
commented
Feb 17, 2020
| @@ -63,7 +63,7 @@ | |||
| }, | |||
|
|
|||
| getDateRange: function () { | |||
| return [this.dateInPeriod, this.dateInPeriod]; | |||
| return [new Date(this.dateInPeriod.getTime()), new Date(this.dateInPeriod.getTime())]; | |||
There was a problem hiding this comment.
we need to ensure new date objects are returned here. Otherwise only references for this.dateInPeriod were returned, causing problems when they were manipulated. (That caused day periods compared two years back)
|
LGTM |
|
Hello there! |
|
The «interval» bug is confirmed also for month period |
tassoman
added a commit
to tassoman/matomo
that referenced
this pull request
Jun 1, 2020
Closed
tassoman
pushed a commit
to tassoman/matomo
that referenced
this pull request
Jun 3, 2020
* ensure new date objects are returned * return chosen period when comparing with previous year
tsteur
pushed a commit
that referenced
this pull request
Jun 3, 2020
jonasgrilleres
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 22, 2020
* ensure new date objects are returned * return chosen period when comparing with previous year Co-authored-by: Stefan Giehl <stefan@matomo.org>
jbuget
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 26, 2020
* ensure new date objects are returned * return chosen period when comparing with previous year Co-authored-by: Stefan Giehl <stefan@matomo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #15194, #15193