During archive invalidation clear general cache less often #15577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
changed the title
|
Looks good to me, some suggestions:
|
|
@diosmosis removed the other clear cache as well 👍 |
jonasgrilleres
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 22, 2020
…g#15577) * Clear general cache less often during archiving * add comment * remove not needed clear cache
jbuget
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 26, 2020
…g#15577) * Clear general cache less often during archiving * add comment * remove not needed clear cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know the code is not ideal since everyone who calls
forgetRememberedArchivedReportsToInvalidatewould need to know to ideally also invalidate the general tracker cache. On the other side we're seeing quite a lot of invalidations like sometimes 50 invalidations within a few ms causing heaps of cache invalidations and cache re-generations across many servers within few ms potentially resulting in locks and temporary performance issues.Maybe this helps to prevent also things like #15545
@diosmosis maybe you can have a look? Maybe since the code is only used internally it may be fine like that?