Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tracker js files from custom plugin directories #15568

Merged
merged 1 commit into from Feb 16, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Feb 13, 2020

When a plugin was not placed in the regular $matomoInstall/plugins directory but in some alternative directory, then the tracker.js or tracker.min.js was not found. Therefore had to change the logic so that all tracker files can be found correctly. This is needed for WordPress as otherwise some plugins don't work there.

@tsteur tsteur added the Needs Review PRs that need a code review label Feb 13, 2020
@tsteur tsteur added this to the 3.13.3 milestone Feb 13, 2020
tsteur added a commit to matomo-org/matomo-for-wordpress that referenced this pull request Feb 13, 2020
@tsteur tsteur merged commit a19d8cf into 3.x-dev Feb 16, 2020
@tsteur tsteur deleted the customjsdirfinder branch February 16, 2020 19:51
tsteur added a commit that referenced this pull request Mar 26, 2020
Regression from #15568

When running JS tests like https://foo.bar/tests/javascript/ then the tracker.js of tracking plugins was no longer included in the matomo.js
diosmosis pushed a commit that referenced this pull request Apr 1, 2020
Regression from #15568

When running JS tests like https://foo.bar/tests/javascript/ then the tracker.js of tracking plugins was no longer included in the matomo.js
jonasgrilleres pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 22, 2020
jonasgrilleres pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 22, 2020
Regression from matomo-org#15568

When running JS tests like https://foo.bar/tests/javascript/ then the tracker.js of tracking plugins was no longer included in the matomo.js
jbuget pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 26, 2020
jbuget pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 26, 2020
Regression from matomo-org#15568

When running JS tests like https://foo.bar/tests/javascript/ then the tracker.js of tracking plugins was no longer included in the matomo.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants