Add UI test for JavaScript tracking. #15567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
requested changes
Feb 14, 2020
|
|
||
| parent::performSetUp($setupEnvironmentOnly); | ||
|
|
||
| $this->testEnvironment->overlayUrl = UiTestFixture::getLocalTestSiteUrl(); |
There was a problem hiding this comment.
The fixture fails to set up here
PHP Fatal error: Class 'Piwik\Tests\Fixtures\UiTestFixture' not found in /home/travis/build/matomo-org/matomo/tests/PHPUnit/Fixtures/JSTrackingUIFixture.php on line 46
| // visit visitor log for correct date | ||
| await page.goto(visitorLogUrl); | ||
|
|
||
| expect(await page.screenshot({ fullPage: true })).to.matchImage('visitor_log'); |
There was a problem hiding this comment.
the expected image for that test is missing
There was a problem hiding this comment.
Seems something doesn't work here. Last processed screenshot shows en empty visitor log:
There was a problem hiding this comment.
Yeah, it works when it runs by itself, but not w/ other tests. Will be fun to debug.
diosmosis
force-pushed
the
new-js-tracking-test
branch
from
adc0a6a
to
d37b960
Compare
mattab
added
the
not-in-changelog
jonasgrilleres
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 22, 2020
* Add UI test for JavaScript tracking. * apply some review feedback * try to fix UI test on travis * Add missing screenshot. * Normalize JSTracker UI test result. * update screenshot
jbuget
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 26, 2020
* Add UI test for JavaScript tracking. * apply some review feedback * try to fix UI test on travis * Add missing screenshot. * Normalize JSTracker UI test result. * update screenshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot that #15374 also contained a UI test for JS tracking so re-creating it. Just changes to tests so adding to 3.13.3 (also updated puppeteer in the samesite PR)