Fix some failing tests #15564
Merged
Fix some failing tests #15564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sgiehl
commented
Feb 13, 2020
•
sgiehl
commented
- Opt-Out UI test was currently failing as the https warning is displayed. That didn't show up in build artifacts as the same screenshot name was reused
sgiehl
added
c: Tests & QA
sgiehl
commented
Feb 13, 2020
| } | ||
|
|
||
| async function loginUser(username, doAuth) | ||
| { | ||
| // make sure to log out previous session | ||
| await page.goto(logoutUrl); | ||
|
|
||
| var cookies = await page.cookies(); | ||
| cookies.forEach(cookie => { | ||
| page.deleteCookie(cookie); |
There was a problem hiding this comment.
It seems in tests logging out doesn't kill cookies, and so the some session data is still available. That caused some 2fa tests to fail, as the password verify was still stored and not triggered again
sgiehl
commented
Feb 13, 2020
| expect(await page.screenshotSelector('.usersManager')).to.matchImage('permissions_edit'); | ||
| expect(await page.screenshotSelector('.usersManager')).to.matchImage({ | ||
| imageName: 'permissions_edit', | ||
| comparisonThreshold: 0.0005, |
There was a problem hiding this comment.
this and the following tests often failed randomly as some pixels of the permission boxes and drop downs were slightly different. Adding that small threshold shouldn't hurt, but they should fail less often
sgiehl
commented
Feb 13, 2020
| @@ -77,7 +77,7 @@ | |||
| class Fixture extends \PHPUnit_Framework_Assert | |||
| { | |||
| const IMAGES_GENERATED_ONLY_FOR_OS = 'linux'; | |||
| const IMAGES_GENERATED_FOR_PHP = '5.6'; | |||
| const IMAGES_GENERATED_FOR_PHP = '7.2'; | |||
There was a problem hiding this comment.
Because of that some scheduled report tests were not executed at all. Adjusted the expected files as well, so the tests pass again :-)
sgiehl
commented
Feb 13, 2020
| a:5:{i:2008;a:0:{}i:2009;a:0:{}i:2010;a:0:{}i:2011;a:0:{}i:2012;a:9:{s:9:"nb_visits";d:311;s:10:"nb_actions";d:708;s:19:"nb_visits_converted";d:245;s:12:"bounce_count";d:166;s:16:"sum_visit_length";d:96791;s:11:"max_actions";d:20;s:11:"bounce_rate";s:3:"53%";s:20:"nb_actions_per_visit";d:2.3;s:16:"avg_time_on_site";s:9:"5 min 11s";}} |
There was a problem hiding this comment.
Guess that changed due to the php version change
sgiehl
added
the
Pull Request WIP
sgiehl
force-pushed
the
fixuitest
branch
2 times, most recently
from
2ec085b
to
2027d24
Compare
sgiehl
force-pushed
the
fixuitest
branch
2 times, most recently
from
becd20f
to
1b3d901
Compare
sgiehl
removed
the
Pull Request WIP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.