Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PHP serialization response format #15558

Merged
merged 4 commits into from Mar 22, 2020
Merged

Remove PHP serialization response format #15558

merged 4 commits into from Mar 22, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Feb 12, 2020

fixes #8100

@sgiehl sgiehl added this to the 4.0.0 milestone Feb 12, 2020
@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Feb 12, 2020
@sgiehl sgiehl force-pushed the removephpformat branch 9 times, most recently from 72d6d97 to 510971b Compare February 12, 2020 16:34
@sgiehl sgiehl added the Needs Review PRs that need a code review label Feb 12, 2020
@sgiehl sgiehl marked this pull request as ready for review February 12, 2020 17:12
tsteur
tsteur requested changes Feb 12, 2020
View reviewed changes
Copy link
Member

@tsteur tsteur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested it yet but left a comment re the archiver

core/CronArchive.php Show resolved Hide resolved
plugins/API/API.php Show resolved Hide resolved
@sgiehl sgiehl force-pushed the removephpformat branch 3 times, most recently from 430a7f4 to b19ecc8 Compare February 18, 2020 08:53
@sgiehl sgiehl force-pushed the removephpformat branch 2 times, most recently from c024362 to 653a714 Compare February 27, 2020 21:39
@tsteur
Copy link
Member

tsteur commented Mar 20, 2020

@sgiehl one more test still seems to be failing and then should be good to merge https://travis-ci.org/github/matomo-org/matomo/jobs/655982878#L893

@sgiehl
Copy link
Member Author

sgiehl commented Mar 21, 2020

@tsteur test should be fixed now

@tsteur tsteur merged commit a4e4f3d into 4.x-dev Mar 22, 2020
@tsteur tsteur deleted the removephpformat branch March 22, 2020 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsteur tsteur tsteur requested changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Reporting API: remove the PHP serialization response format
2 participants
@sgiehl @tsteur