Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use \PHPUnit\Framework\TestCase instead of \PHPUnit_Framework_TestCase #15554

Merged
merged 1 commit into from Feb 11, 2020
Merged

Use \PHPUnit\Framework\TestCase instead of \PHPUnit_Framework_TestCase #15554

merged 1 commit into from Feb 11, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Feb 11, 2020

Newer versions of PHPUnit will only support new namespace structure. our used (very old) version already implements a simple forward compatibility for that class, so already replacing it is simple and will make an update of PHPUnit easier later

(will do that for the other repos as well)

@sgiehl sgiehl added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Feb 11, 2020
@sgiehl sgiehl added this to the 4.0.0 milestone Feb 11, 2020
@sgiehl sgiehl merged commit cce28d0 into 4.x-dev Feb 11, 2020
@sgiehl sgiehl deleted the phpunitns branch February 11, 2020 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@sgiehl