Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Provider plugin to the Marketplace #15552

Merged
merged 10 commits into from Feb 12, 2020
Merged

Move Provider plugin to the Marketplace #15552

merged 10 commits into from Feb 12, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Feb 11, 2020

fix #5341

plugin is now its own repo https://github.com/matomo-org/plugin-Provider

@tsteur tsteur added Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Feb 11, 2020
@tsteur tsteur added this to the 4.0.0 milestone Feb 11, 2020
@tsteur tsteur added Needs Review PRs that need a code review and removed Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels Feb 11, 2020
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering what happens when doing the update. I guess the plugin wouldn't be removed automatically, even though it isn't included in the archive anymore. But actually it would then lack the plugin.json and thus it would be reported as not compatible? 🤔

.gitmodules Show resolved Hide resolved
@tsteur
Copy link
Member Author

tsteur commented Feb 11, 2020

@sgiehl just double checked again it will recognise it's not in core and then ask the Marketplace for an update.

@sgiehl
Copy link
Member

sgiehl commented Feb 12, 2020

ok. Then guess it's fine if we release a version of the plugin on the marketplace before releasing Matomo 4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Provider plugin to the Marketplace
2 participants