Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds action for building tracker js files #15542

Merged
merged 1 commit into from Feb 12, 2020
Merged

Adds action for building tracker js files #15542

merged 1 commit into from Feb 12, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Feb 10, 2020

This action will make it possible to automatically update the minified tracker js files in a Pull Request.
It is triggered with a comment "build js" within a Pull Request.

It (currently) only works for Pull Requests that are based on a local branch.

@sgiehl sgiehl added the Needs Review PRs that need a code review label Feb 10, 2020
@sgiehl sgiehl added this to the 4.0.0 milestone Feb 10, 2020
This action will make it possible to automatically update the minified tracker js files.
It is triggered with a comment "build js" within a Pull Request.

It (currently) only works for Pull Requests that are based on a local branch.
@tsteur
Copy link
Member

tsteur commented Feb 11, 2020

What will be the best way to test this?

@sgiehl
Copy link
Member Author

sgiehl commented Feb 11, 2020

Hm... I've developed & tested those actions on a fork. They need to be placed in the default branch (4.x-dev) to be executed

@tsteur
Copy link
Member

tsteur commented Feb 11, 2020

OK feel free to merge tmrw and in worst case simply revert 👍

1 similar comment
@tsteur
Copy link
Member

tsteur commented Feb 11, 2020

OK feel free to merge tmrw and in worst case simply revert 👍

@sgiehl sgiehl merged commit b07e8cf into 4.x-dev Feb 12, 2020
@sgiehl sgiehl deleted the trackerjsaction branch February 12, 2020 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants