Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RedisCache warning not fixed in 3.13.1 #15532

Closed
ghost opened this issue Feb 7, 2020 · 2 comments
Closed

RedisCache warning not fixed in 3.13.1 #15532

ghost opened this issue Feb 7, 2020 · 2 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
3.13.2

Comments

@ghost
Copy link

ghost commented Feb 7, 2020 •
edited by ghost

In Matomo 3.13.1 the changelog states that this issue was fixed:

23 Update dependencies: Warning RedisCache.php(135): Deprecated – Function Redis::delete() is deprecated

However, the older version of: "Common/Cache/RedisCache.php" is included in the release which does not have the fix. Specifically, in the Matomo 3.13.1 build, see the file: "Common/Cache/RedisCache.php" includes "$this->redis->delete" and not the corrected code: "$this->redis->del". Perhaps an incorrect branch of "cache" was used to build Matomo 3.13.1?

matomo-org/component-cache#23
@tsteur tsteur mentioned this issue Feb 9, 2020
Merged
@tsteur
Copy link
Member

tsteur commented Feb 9, 2020

Cheers, this wasn't fixed for the 1.X version of the cache component. Created a PR in matomo-org/component-cache#27 and maybe we get this into 3.13.2 release which should be today.

@tsteur tsteur added this to the 3.13.2 milestone Feb 9, 2020
@tsteur tsteur added Regression Indicates a feature used to work in a certain way but it no longer does even though it should. Bug For errors / faults / flaws / inconsistencies etc. and removed Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Feb 9, 2020
@tsteur tsteur mentioned this issue Feb 9, 2020
Merged
@mattab
Copy link
Member

mattab commented Feb 10, 2020

Will be fixed in 3.13.2

@mattab mattab closed this as completed Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
3.13.2
Development

No branches or pull requests
2 participants
@tsteur @mattab