Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for up to 4 fields to multipairfield #15531

Merged
merged 4 commits into from Feb 10, 2020
Merged

Add support for up to 4 fields to multipairfield #15531

merged 4 commits into from Feb 10, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Feb 7, 2020

recreates #15125

Add support for up to 4 fields to multipairfield (#15125)
f3a6eb3 
* Add support for up to 4 fields to multipairfield

* Add support for up to 4 fields to multipairfield
@sgiehl sgiehl added this to the 4.0.0 milestone Feb 7, 2020
@sgiehl
Copy link
Member Author

sgiehl commented Feb 7, 2020

@tsteur remaining UI failures are unrelated. Guess would be good to merge.

@sgiehl sgiehl marked this pull request as ready for review February 7, 2020 14:54
@sgiehl sgiehl requested a review from tsteur February 7, 2020 14:54
tsteur
tsteur requested changes Feb 9, 2020
View reviewed changes
Copy link
Member

@tsteur tsteur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment. Be good to look at it. Also there's some other issue see video. You enter a value and then the other fields get the same value

Feb-10-2020 07-59-44

@mattab mattab added Needs Review PRs that need a code review Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels Feb 10, 2020
@sgiehl sgiehl removed the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Feb 10, 2020
@sgiehl
Copy link
Member Author

sgiehl commented Feb 10, 2020

Left a comment. Be good to look at it. Also there's some other issue see video. You enter a value and then the other fields get the same value

That was because the keys of all fields were the same. adjusted that...

@sgiehl sgiehl force-pushed the multipairfield_4_field_support branch from d4f4717 to 9d44e9f Compare February 10, 2020 10:34
@tsteur tsteur merged commit a4d4e15 into 4.x-dev Feb 10, 2020
@tsteur tsteur deleted the multipairfield_4_field_support branch February 10, 2020 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsteur tsteur tsteur requested changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sgiehl @tsteur @mattab