Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Content interaction tracking fails if banner is enclosed by A element with external link #15529

Closed
peterbo opened this issue Feb 7, 2020 · 2 comments
Closed

Content interaction tracking fails if banner is enclosed by A element with external link #15529

peterbo opened this issue Feb 7, 2020 · 2 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
4.0.0

Comments

@peterbo
Copy link
Contributor

peterbo commented Feb 7, 2020 •
edited

The issued request looks like this: https://matomo.dev/piwik.php?link=https://example.com/&c_i=click&c_n=[content-name]&c_p=[content-piece]&c_t=[content-target]&idsite=1&[...]

E.g.
<a href="https://example.com/" target="_blank"> <img src="image.svg" data-track-content="data-track-content" data-content-name="[content-name]" data-content-piece="[content-piece]"> </a>

If href is an internal link, content tracking works as expected.
@peterbo peterbo changed the title Content tracking fails if banner is enclosed by A element with external link Content interaction tracking fails if banner is enclosed by A element with external link Feb 7, 2020
@tsteur
Copy link
Member

tsteur commented Feb 7, 2020

Haven't tried it yet but this may be fixed by https://github.com/matomo-org/matomo/pull/15406/files in Matomo 4

@peterbo
Copy link
Contributor Author

peterbo commented Feb 7, 2020

Looks good, thanks for answering, Thomas! I'll close and test asap, and reopen, if necessary.

@peterbo peterbo closed this as completed Feb 7, 2020
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Feb 10, 2020
@mattab mattab added this to the 4.0.0 milestone Feb 10, 2020
@troehrkasse troehrkasse mentioned this issue May 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
3 participants
@tsteur @mattab @peterbo