@mattab opened this Issue on February 7th 2020 Member

Issue reproduced on the demo: https://demo.matomo.org/index.php?module=CoreHome&action=index&date=today&period=week&idSite=62&updated=2#?idSite=62&period=week&date=2020-02-01&category=Referrers_Referrers&subcategory=General_Overview
This issue is visible to everyone on the demo it seems (in a private browser window)
but i could not reproduce it on other instances.

Here is how it looks:

Screenshot from 2020-02-07 13-18-58

  • Got evolution graphs showing "Clicks" metrics for Direct entries and Total
  • Expected instead evolution graphs showing "Visits" metrics for Direct entries and Total

What could cause such an issue of plotting the wrong metrics?

I could try to run the SQL in this FAQ for "anonymous" user but I expected that anonymous would never get any setting stored (as the settings are expected to be stored in each anonymous' user session)

@mattab commented on February 7th 2020 Member
@tsteur commented on February 7th 2020 Member

@mattab this is only happening for ProxySite as mentioned the other day. Not for a regular site.

@tsteur commented on February 11th 2020 Member

BTW It looks like this regressed as part of 3.13.1, not 3.13.2 still looking into things

@tsteur commented on February 11th 2020 Member

FYI @diosmosis it is caused by https://github.com/matomo-org/matomo/commit/2915d75f69f2340ee6dcf1a9f4401b658fb8c966 the change from disable_datatable_post_processing to disable_root_datatable_post_processor https://github.com/matomo-org/matomo/blame/3.x-dev/core/Plugin/Visualization.php#L336

and I think as a result column names are not replaced for example but I suppose this might be only one of the side effects. Can you maybe have a look?

@diosmosis commented on February 11th 2020 Member

@tsteur / @mattab Oh yes, I noticed this, I have a fix (applied to demo) but I'm not sure if there will be any side effects. ProxySite's UI tests aren't working anymore (possibly due to 4.0 in some way).

@tsteur commented on February 11th 2020 Member
@tsteur commented on February 11th 2020 Member

BTW not sure it is a side effect or related... but looks like maybe sorting doesn't work correctly anymore?
https://demo.matomo.org/index.php?module=CoreHome&action=index&idSite=62&period=day&date=yesterday#?idSite=62&period=day&date=yesterday&segment=&category=General_Visitors&subcategory=DevicesDetection_Software

Seems to be sorted by label instead of unique visitors?
image

@diosmosis commented on February 11th 2020 Member

That's annoying, too many side effects. The issue is that Archive.php queues some filters to every report, but w/ disable_root_datatable_post_processor, they are no longer applied in the target. Removing disable_root_datatable_post_processor would of course break something else. I wonder if we're at the limit of what ProxySite can do given matomo's current architecture.

@tsteur commented on February 11th 2020 Member

Yeah that's possible. Not using disable_root_datatable_post_processor was breaking some comparison feature I suppose?

@diosmosis commented on February 11th 2020 Member

Yes, possibly pivotBy too. I can't remember the details, but they involved ViewDataTable and were somewhat confusing.

@mattab commented on February 11th 2020 Member

The demo now looks good and working, even sorting seems to work for me?

Thanks!

@diosmosis commented on February 11th 2020 Member

@mattab I only modified some code in demo, it will require a PR, but I found another comparison issue locally.

This Issue was closed on February 11th 2020
Powered by GitHub Issue Mirror