Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo.matomo.org does not show correct data #15527

Closed
mattab opened this issue Feb 7, 2020 · 12 comments
Closed

Demo.matomo.org does not show correct data #15527

mattab opened this issue Feb 7, 2020 · 12 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Feb 7, 2020

Issue reproduced on the demo: https://demo.matomo.org/index.php?module=CoreHome&action=index&date=today&period=week&idSite=62&updated=2#?idSite=62&period=week&date=2020-02-01&category=Referrers_Referrers&subcategory=General_Overview
This issue is visible to everyone on the demo it seems (in a private browser window)
but i could not reproduce it on other instances.

Here is how it looks:

Screenshot from 2020-02-07 13-18-58

  • Got evolution graphs showing "Clicks" metrics for Direct entries and Total
  • Expected instead evolution graphs showing "Visits" metrics for Direct entries and Total

What could cause such an issue of plotting the wrong metrics?

I could try to run the SQL in this FAQ for "anonymous" user but I expected that anonymous would never get any setting stored (as the settings are expected to be stored in each anonymous' user session)

@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Feb 7, 2020
@mattab mattab added this to the 3.13.2 milestone Feb 7, 2020
@mattab mattab changed the title Acquisition > Overview evolution graph sometimes does not show metrics Demo.matomo.org does not show correct data Feb 7, 2020
@tsteur
Copy link
Member

tsteur commented Feb 7, 2020

@mattab this is only happening for ProxySite as mentioned the other day. Not for a regular site.

@mattab mattab modified the milestones: 3.13.2, 4.0.0 Feb 10, 2020
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Feb 10, 2020
@tsteur
Copy link
Member

tsteur commented Feb 11, 2020

BTW It looks like this regressed as part of 3.13.1, not 3.13.2 still looking into things

@tsteur
Copy link
Member

tsteur commented Feb 11, 2020

FYI @diosmosis it is caused by 2915d75 the change from disable_datatable_post_processing to disable_root_datatable_post_processor https://github.com/matomo-org/matomo/blame/3.x-dev/core/Plugin/Visualization.php#L336

and I think as a result column names are not replaced for example but I suppose this might be only one of the side effects. Can you maybe have a look?

@diosmosis
Copy link
Member

@tsteur / @mattab Oh yes, I noticed this, I have a fix (applied to demo) but I'm not sure if there will be any side effects. ProxySite's UI tests aren't working anymore (possibly due to 4.0 in some way).

@tsteur
Copy link
Member

tsteur commented Feb 11, 2020

@tsteur
Copy link
Member

tsteur commented Feb 11, 2020

BTW not sure it is a side effect or related... but looks like maybe sorting doesn't work correctly anymore?
https://demo.matomo.org/index.php?module=CoreHome&action=index&idSite=62&period=day&date=yesterday#?idSite=62&period=day&date=yesterday&segment=&category=General_Visitors&subcategory=DevicesDetection_Software

Seems to be sorted by label instead of unique visitors?
image

@diosmosis
Copy link
Member

That's annoying, too many side effects. The issue is that Archive.php queues some filters to every report, but w/ disable_root_datatable_post_processor, they are no longer applied in the target. Removing disable_root_datatable_post_processor would of course break something else. I wonder if we're at the limit of what ProxySite can do given matomo's current architecture.

@tsteur
Copy link
Member

tsteur commented Feb 11, 2020

Yeah that's possible. Not using disable_root_datatable_post_processor was breaking some comparison feature I suppose?

@diosmosis
Copy link
Member

Yes, possibly pivotBy too. I can't remember the details, but they involved ViewDataTable and were somewhat confusing.

@mattab
Copy link
Member Author

mattab commented Feb 11, 2020

The demo now looks good and working, even sorting seems to work for me?

Thanks!

@mattab mattab closed this as completed Feb 11, 2020
@diosmosis
Copy link
Member

@mattab I only modified some code in demo, it will require a PR, but I found another comparison issue locally.

@mattab mattab removed the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Feb 24, 2020
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

No branches or pull requests

3 participants