Removes GeoIp Legacy support #15521
Merged
Removes GeoIp Legacy support #15521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
the
not-in-changelog
sgiehl
force-pushed
the
removegeoiplegacy
branch
4 times, most recently
from
1b0a304
to
3f09bc4
Compare
sgiehl
force-pushed
the
removegeoiplegacy
branch
3 times, most recently
from
0a95129
to
7d9b0f4
Compare
sgiehl
force-pushed
the
removegeoiplegacy
branch
from
7d9b0f4
to
08b16de
Compare
sgiehl
force-pushed
the
removegeoiplegacy
branch
from
08b16de
to
15e1c2b
Compare
diosmosis
reviewed
Feb 25, 2020
diosmosis
reviewed
Feb 25, 2020
|
|
||
| it('should show geolocation admin without additional providers', async function () { | ||
| testEnvironment.unloadGeoIp2 = 1; | ||
| testEnvironment.save(); |
There was a problem hiding this comment.
minor suggestion: instead of a unloadGeoIp2 setting, we could have a pluginsToUnload setting that could be re-used in other contexts for other plugins. what do you think of that idea?
There was a problem hiding this comment.
makes sense. change that.
|
Tested locally, seems to work for me, even going back to 3.x-dev. Left a couple comments otherwise. |
sgiehl
force-pushed
the
removegeoiplegacy
branch
from
15e1c2b
to
8c1e73a
Compare
sgiehl
force-pushed
the
removegeoiplegacy
branch
from
8c1e73a
to
fcafee4
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: For users still using GeoIp Legacy, the update will switch their provider back to the default one.
fixes #13957