Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change description for segments visitEndServer* #15518

Merged
merged 2 commits into from May 26, 2020

Conversation

toredash
Copy link
Contributor

@toredash toredash commented Feb 5, 2020

visitEndServer* does not show when a visits ends, but when the last action for the visit was.

Modifications for other languages should be done as well

@toredash
Copy link
Contributor Author

toredash commented Feb 5, 2020

closes #15179

@tsteur
Copy link
Member

tsteur commented Feb 6, 2020

👍 @mattab can you have a quick look here?
@toredash we'll need to fix some tests like the ones failing here. https://travis-ci.org/matomo-org/matomo/jobs/646313431?utm_medium=notification&utm_source=github_status Have you done this before? We might be able to merge it and then fix the tests in a separate PR

@tsteur tsteur requested a review from mattab February 6, 2020 21:11
@toredash
Copy link
Contributor Author

toredash commented Feb 7, 2020

@tsteur No I haven't done this before. Looked at the builds and I altered one test that is related to this PR. Waiting for the build results now

@toredash
Copy link
Contributor Author

toredash commented Feb 7, 2020

@tsteur I'm not sure where I go in the code to resolve these;
https://travis-ci.org/matomo-org/matomo/jobs/647297552#L966

If you could point me to the correct location that would probably help, thanks

@tsteur tsteur added the Needs Review PRs that need a code review label Feb 10, 2020
@tsteur tsteur added this to the 4.0.0 milestone Feb 10, 2020
@mattab
Copy link
Member

mattab commented Feb 11, 2020

@toredash to fix this test, you can do the same as you did for the other test ie. overwrite the files within the folder plugins/Live/tests/System/expected/test_actionSegment__*.xml by the files that were in the plugins/Live/tests/System/processed folder on your machine after you ran the tests and generated the new correct responses.

@tsteur tsteur changed the base branch from 4.x-dev to m15991 May 26, 2020 22:05
@tsteur
Copy link
Member

tsteur commented May 26, 2020

@toredash I'll merge this now in a branch on our side so I can fix the tests afterwards. THanks for this 👍

@tsteur tsteur merged commit 655f5aa into matomo-org:m15991 May 26, 2020
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants