@sgiehl opened this Pull Request on February 3rd 2020 Member

fixes #13604

@tsteur commented on February 3rd 2020 Member

@sgiehl there used to be a plugin on the marketplace named CustomTrackerJs... just wondering if someone updates from Piwik 2.X to Matomo 4.X if this could cause any issues? I suppose that plugin would be simply overwritten? (which be kind of good since it would also automatically remove an outdated / not compatbile plugin) or is easier to rename it to CustomJsTracker?

@sgiehl commented on February 4th 2020 Member

Guess it would be overwritten, but not sure if some old files might remain 🤷‍♂
Not having a preference here. Can also rename it...

@tsteur commented on February 4th 2020 Member

Up to you. If we keep the name, might be worth testing what happens when upgrading from Piwik 2 and such a plugin existed. Might be easier to maybe rename it?

@sgiehl commented on February 5th 2020 Member

renamed it again. Need to update the UI tests again, I guess. But should be ready for another review

@sgiehl commented on February 7th 2020 Member

@tsteur applied the feedback

@tsteur commented on February 9th 2020 Member

Looks good in general @sgiehl some tests will need fixing though

@sgiehl commented on February 10th 2020 Member

Guess tests are failing because the changes in tagmanager are needed. will push a submodule change to prove that.

@sgiehl commented on February 10th 2020 Member

Tests seem to pass again. Before merging we need to merge https://github.com/matomo-org/tag-manager/pull/220 and update the submodule ref here.

This Pull Request was closed on February 11th 2020
Powered by GitHub Issue Mirror