New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracker API: trim spaces in event names, category, actions #15501
Comments
sounds good |
Hi @mattab and @tsteur I believe the I checked the I check the other request parameters too. EDITED: I checked the other parameters and they all looking good to me: either not string, or goes through some kind of validation or trimmed. |
@mattab looks indeed like event names etc are already trimmed (by looking at code, not reproducing). Do we maybe otherwise still have the link to the original conversation? |
@tsteur sure, you can find it in conversation #641565 |
Here is what user wrote:
Before:
Before (original report):
|
Thanks @mattab, it's useful. In this case indeed the action name was the problem. The PR will fix that. |
@mattab it seems all action/event names are meanwhile already trimmed. The funnel problem was already solved in a L3 issues, so guess there is actually nothing left to do here. If the user is still having that issue, maybe he can describe the issue a bit more clearly, so it's easier for us to look for a potential reason. |
closing for now and we can reopen if that should appear again. |
Currently in the Tracker API we do trim content names, pieces, targets strings. To be consistent we could also trim event names (
e_n
), event category (e_c
), event actions (e_a
).We could even trim a couple of other inputs where it could make sense like Page title (
action_name
), possibly site search keyword (search
,search_cat
).fyi: creating this issue as a result of a user and developer getting confused about duplicate data in an Events report.
Problem solved by "invisible empty space".
The text was updated successfully, but these errors were encountered: