Refs #3505 DevicesDetection plugin - provides detection of TVs #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Solfire Thanks for the PR! It would be very useful to have TV detection and in general increase the quality of Devices detection algorithms. Maybe you could update it to latest Git master? the format of tests fixturess changed (they make more sense now with the new "device" category). (I cannot merge the PR as is) Cheers! |
|
I'll move/copy the changes to my pull request. So we will be able to merge them in. |
|
Kaboom Stefan, good to hear you're leading the way with our DevicesDetection plugin! |
|
Sorry for the late replay, but i hadn't enough time to make the needed changes to the format of tests fixtures ... |
sgiehl
added a commit
that referenced
this pull request
Feb 5, 2014
added detection of 'LG Browser' and 'Espial TV Browser' added a bunch of test cases
|
Nevermind. I'll push the changes to PR #213 |
|
Great 👍 ty |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update provides detecting TVs with the DevicesDetection plugin based on the UserAgent.
Testet with several devices (see picture attached):