Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated supported currencies: Added Bitcoin #15496

Closed
wants to merge 1 commit into from
Closed

Updated supported currencies: Added Bitcoin #15496

wants to merge 1 commit into from

Conversation

cd2357
Copy link

@cd2357 cd2357 commented Jan 31, 2020

For sites that denominate their Goals in BTC

For sites that denominate their Goals in BTC
@tsteur
Copy link
Member

tsteur commented Feb 2, 2020

Looks good to me. Any thoughts @sgiehl ?

@tsteur tsteur added this to the 4.0.0 milestone Feb 2, 2020
@tsteur tsteur added the Needs Review PRs that need a code review label Feb 2, 2020
@sgiehl
Copy link
Member

sgiehl commented Feb 2, 2020

the file currently only holds currencies, that have a valid iso code. None of the crypto currencies currently has a valid iso code.
Also Bitcoin is already predefined in global.ini.php. See

; Add custom currencies to Sites Manager.
currencies[BTC] = Bitcoin

So as long as that config value is not overwritten somewhere, it should already be available without that change.

@cd2357 wasn't bitcoin available for you without that change? Or what's the purpose?

@cd2357
Copy link
Author

cd2357 commented Feb 2, 2020

Well, I had just recently installed a fresh version of Matomo 3.13.1. I noticed that under Websites > Manage, there's a currency field ("The Currency symbol will be displayed next to Goals revenues.")

Now since I wanted to track goal revenues in BTC, I figured I'd select or somehow enter that. But the list of available currencies didn't show it. So I figured I'd add it. That's the background behind the commit.

@sgiehl
Copy link
Member

sgiehl commented Feb 3, 2020

Interesting. For me Bitcoin appears in the list of currencies without that change 🤔

@tsteur
Copy link
Member

tsteur commented Feb 3, 2020

It's definitely already there for me as well. Maybe double check your config/global.ini.php whether it mentions that currency? I'll close this for now as it should work. Happy to reopen or further discuss if there's a problem @cd2357

@tsteur tsteur closed this Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants