Fix tests #15495
Closed
Fix tests #15495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tsteur is it fine to change those tests? guess it won't make a big difference, but at least fix the tests for now. |
|
@sgiehl be great if we had some reminder that we need to change them back to Wonder how to best achieve this? I suppose we could instead skip the test but we'd still forget to change them back. $this->assertDeprecatedMethodIsRemovedInPiwikVersion('4.0.0-rc1', $className, $method);and then some method name like |
|
closing in favor of #15622 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some tests in Matomo v4.x, specific count values were used however v4.x only returns 6 plugins matches. I've changed the check to >0 as it shouldn't really matter how many are returned as long as there is plugin data returned from the marketplace.