@limitstudios opened this Pull Request on January 30th 2020 Contributor

This fixes some tests in Matomo v4.x, specific count values were used however v4.x only returns 6 plugins matches. I've changed the check to >0 as it shouldn't really matter how many are returned as long as there is plugin data returned from the marketplace.

@sgiehl commented on February 6th 2020 Member

@tsteur is it fine to change those tests? guess it won't make a big difference, but at least fix the tests for now.

@tsteur commented on February 6th 2020 Member

@sgiehl be great if we had some reminder that we need to change them back to 15 again later.

Wonder how to best achieve this? I suppose we could instead skip the test but we'd still forget to change them back.
Maybe we could somehow misuse DeprecatedMethodsTest to have a reminder like

        $this->assertDeprecatedMethodIsRemovedInPiwikVersion('4.0.0-rc1', $className, $method);

and then some method name like Pr15495ExpectPluginsBeReturnedFromAPIagain or so?

@sgiehl commented on February 25th 2020 Member

closing in favor of #15622

This Pull Request was closed on February 25th 2020
Powered by GitHub Issue Mirror