New INI setting delete_logs_unused_actions_max_rows_per_query useful for speeding up deletion process for very large sites #15492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Intended to be used to improve performance for large sites, similar to delete_logs_max_rows_per_query and archiving_ranking_query_row_limit
tsteur
requested changes
Jan 31, 2020
| $settings['delete_reports_keep_range_reports'] = (int) $keepRange; | ||
| $settings['delete_reports_keep_segment_reports'] = (int) $keepSegments; | ||
| $settings['delete_logs_max_rows_per_query'] = PiwikConfig::getInstance()->Deletelogs['delete_logs_max_rows_per_query']; | ||
| $settings['delete_logs_unused_actions_max_rows_per_query'] = PiwikConfig::getInstance()->Deletelogs['delete_logs_unused_actions_max_rows_per_query']; |
There was a problem hiding this comment.
AFAIK it shouldn't be needed to add this here?
There was a problem hiding this comment.
I'll remove it then :) thanks
There was a problem hiding this comment.
Given that we have the new setting present in Controller.php, I assume we need it here as well.
|
closes #15484 |
tsteur
reviewed
Feb 2, 2020
toredash
commented
Feb 4, 2020
| $settings['delete_reports_keep_range_reports'] = (int) $keepRange; | ||
| $settings['delete_reports_keep_segment_reports'] = (int) $keepSegments; | ||
| $settings['delete_logs_max_rows_per_query'] = PiwikConfig::getInstance()->Deletelogs['delete_logs_max_rows_per_query']; | ||
| $settings['delete_logs_unused_actions_max_rows_per_query'] = PiwikConfig::getInstance()->Deletelogs['delete_logs_unused_actions_max_rows_per_query']; |
There was a problem hiding this comment.
Given that we have the new setting present in Controller.php, I assume we need it here as well.
|
Thanks @toredash very appreciated |
mattab
changed the title
mattab
added
the
c: Performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended to be used to improve performance for large sites, similar to delete_logs_max_rows_per_query and archiving_ranking_query_row_limit