Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable user-defined value for insertIntoTempIterationStep #15491

Closed
wants to merge 23 commits into from

Conversation

toredash
Copy link
Contributor

Intended to be used to improve performance for large sites, similar to delete_logs_max_rows_per_query and archiving_ranking_query_row_limit

sgiehl and others added 23 commits January 13, 2020 17:56
* updates device detector to latest release

* updates tests
…5401)

* Lock key start

* do not empty key lock

Co-authored-by: Thomas Steur <tsteur@users.noreply.github.com>
…s/sites if they want. (matomo-org#15457)

* Add event that allows plugins to disable archiving for certain periods/sites if they want.

* apply review feedback
Better patch for matomo-org#15401 which was merged last minute...

This way it always works even when someone calls `acquireLock` directly instead of `execute`

Pushing this for now into 3.x-dev but can also put it into 4.x-dev directly but then there might be merge conflicts when merging 3.x-dev into 4.x-dev
Intended to be used to improve performance, similar to delete_logs_max_rows_per_query and archiving_ranking_query_row_limit
@tsteur
Copy link
Member

tsteur commented Jan 30, 2020

@toredash I believe there are some other commits there probably from 3.x-dev. Could you maybe create a PR with only the actual changes? That be great

@toredash toredash closed this Jan 31, 2020
@toredash toredash deleted the fix/actions-arg branch January 31, 2020 13:55
@mattab mattab added this to the 4.0.0 milestone Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants