Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort Packages #15487

Merged
merged 1 commit into from Jan 30, 2020
Merged

Sort Packages #15487

merged 1 commit into from Jan 30, 2020

Conversation

millnut
Copy link

@millnut millnut commented Jan 29, 2020

Enabled composer sort-packages config, DX improvement

@millnut
Sort Packages
a0379c4 
Enabled composer sort-packages config, DX improvement
@tsteur
Copy link
Member

tsteur commented Jan 29, 2020

@limitstudios cheers. Be great to just quickly mention the benefit of doing it this way. Does it help avoid conflicts or so?

@millnut
Copy link
Author

millnut commented Jan 30, 2020

It's more of a readability thing, so when packages are added/removed they are sorted correctly

@tsteur
Copy link
Member

tsteur commented Jan 30, 2020

👍 thanks

@tsteur tsteur merged commit aeb7aa3 into matomo-org:4.x-dev Jan 30, 2020
@mattab mattab added this to the 4.0.0 milestone Sep 10, 2020
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@millnut @tsteur @mattab