Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two YAML parser #15469

Closed
millnut opened this issue Jan 27, 2020 · 3 comments
Closed

Two YAML parser #15469

millnut opened this issue Jan 27, 2020 · 3 comments
Labels
answered For when a question was asked and we referred to forum or answered it. c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself.

Comments

@millnut
Copy link

millnut commented Jan 27, 2020

Looking at composer it appears there are 2 parsers for working with YAML

  • mustangostang/spyc (in require), and;
  • symfony/yaml (in require-dev)

It doesn't really make sense to require both, so which should be set to be the sole parser, obviously the decision has to take into account PHP 7.2, 7.3, 7.4 compatibility for the v4.x branch

@tsteur tsteur added the c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. label Jan 27, 2020
@tsteur
Copy link
Member

tsteur commented Jan 27, 2020

We're only using mustangostang/spyc AFAIK.

It seems the other one was added in d0c93e6 maybe to avoid some conflict issue. Could be maybe removed by now.

@millnut
Copy link
Author

millnut commented Jan 28, 2020

Ah ok that makes sense. When I upgrade the current symfony packages to 4.4 (LTS) for the 4.x branch I'll remove that if it appears not to be required.

@tsteur
Copy link
Member

tsteur commented Jan 28, 2020

👍

@tsteur tsteur closed this as completed Jan 28, 2020
@mattab mattab added the answered For when a question was asked and we referred to forum or answered it. label Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answered For when a question was asked and we referred to forum or answered it. c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself.
Projects
None yet
Development

No branches or pull requests

3 participants