Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update davaxi/sparkline composer dependency #15458

Closed
creativecoder opened this issue Jan 26, 2020 · 6 comments · Fixed by #15465
Closed

Update davaxi/sparkline composer dependency #15458

creativecoder opened this issue Jan 26, 2020 · 6 comments · Fixed by #15465
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@creativecoder
Copy link

Currently davaxi/sparkline is set to the version dev-multiple-series in composer.json

"davaxi/sparkline": "dev-multiple-series",
)

This results in the following error when running composer require piwik/piwik

Problem 1
    - piwik/piwik 3.13.1 requires davaxi/sparkline dev-multiple-series -> no matching package found.

I believe davaxi/sparkline should instead be set to ~1.2, to install the latest release that includes the changes merged to support displaying multiple series.

@tsteur tsteur added this to the 4.0.0 milestone Jan 27, 2020
@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label Jan 27, 2020
@tsteur
Copy link
Member

tsteur commented Jan 27, 2020

@Findus23 @sgiehl do you maybe know more?

@Findus23
Copy link
Member

@diosmosis should know best about it but I have no idea why this fails. While we should now be using the latest upstream (#15465), the branch still exists and should therefore work in composer (https://github.com/matomo-org/Sparkline/tree/multiple-series)

@diosmosis
Copy link
Member

Maybe caused by a composer setting? I'm not sure why this would fail.

@tsteur
Copy link
Member

tsteur commented Jan 27, 2020

I can reproduce the issue. Not sure why it doesn't work though or how it needs to be configured etc. It looks like we used to use 1.1 so we could change it to 1.2 or so?

@sgiehl
Copy link
Member

sgiehl commented Jan 27, 2020 via email

@millnut
Copy link

millnut commented Jan 30, 2020

@sgiehl looks like a new release maybe coming next week davaxi/Sparkline#15 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants