Process unique visitor metric for Roll-ups (set enable_processing_unique_visitors_multiple_sites = 1) #15450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattab
changed the title
|
@mattab can you recreate the PR against 4.x-dev and then also fix the UI test (there is a diagnostics config test failing) |
diosmosis
force-pushed
the
enable_processing_unique_visitors_multiple_sites
branch
from
3e9d89a
to
a05d910
Compare
…que_visitors_multiple_sites = 1) Alternatively, we could remove this setting completely and always assume we want to process unique visitors across websites. I'm not sure there is any reason not to want this enabled?
sgiehl
force-pushed
the
enable_processing_unique_visitors_multiple_sites
branch
from
4a714c7
to
92827e4
Compare
|
@mattab this PR will very likely cause issues because it will only work when |
mattab
added
the
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternatively, we could remove this setting completely and always assume we want to process unique visitors across websites. I'm not sure there is any reason not to want this enabled?