@gka opened this Issue on August 2nd 2010 Contributor

I would like to adapt the appearance of the chart tooltips to the new UI design. This should be possible by adding simple statements to the chart-api call (see examples).

In the attached screenshot you can see my suggestion for the new tooltips.
Keywords: charts,tooltip

@gka commented on August 2nd 2010 Contributor

Attachment:
tooltips.png

@gka commented on August 2nd 2010 Contributor

Attachment: this is rendered using the patched version of open-flash-charts.swf and an updated version of the map swf. the tooltips integrate nicely into the Piwik UI
tooltips_better.png

@gka commented on August 2nd 2010 Contributor

I just checked if it is possible to customize the tooltip as would like to. Sadly, it's not possible to insert bold text inside of the tooltips body text. It is also impossible to change the text font.

After looking at the source code of open-flash-charts I instantly found the code that limits the customization. The font name "Verdana" is hardcoded in the source. Fortunately it wasn't very difficult to fix this "bug" and the patched version is now committed to the Open Flash Chart tracker at sourceforge. I tested my changes and it works very well. Surprisingly the file size of the open-flash-chart.swf has also reduced from 269kb to 172kb after rebuilding it with the current Flex SDK.

I hope John Glazebrook includes my patch since I don't want to maintain a fork ;)

@robocoder commented on August 2nd 2010 Contributor

I've set the milestone only because it wasn't set.

We may have to discuss and defer to a later target milestone.

We generally don't want to maintain forks of third-party components/libraries. We do make exceptions though, eg for php version compatibility
and bug fixes (which we report upstream).

At this point, OFC's future appears unclear -- it hasn't seen a new release in a year; ditto for the ofcgwt and dz forks.

@mattab commented on August 3rd 2010 Member

Anthon, OFC is dead: http://forums.openflashchart.com/viewtopic.php?f=3&t=2091&p=6457#p6601

I don't see a problem forking considering

  • Greg is a flash specialist
  • We are happy with current features of OFC (ie. we are not waiting for bug fixes or other new features from them)
  • Greg has already done the change :-)

Greg, how should we proceed from there? Looks good to commit to me.

@robocoder commented on August 3rd 2010 Contributor

In that case, we can either fork or contribute the patch to another fork (http://forums.openflashchart.com/viewtopic.php?f=5&t=2344).

For the record, these aren't blockers, but we have encountered OFC bugs:

[[Image(http://forums.openflashchart.com/download/file.php?id=197)]]
[[Image(ticket:1141:screenshot.jpg)]]

@gka commented on August 3rd 2010 Contributor

Since there is no ongoing development on OFC, I suggest we should fork it in order maintain at least a stable and bug-free version that we can use for Piwik until the time is right to switch to SVG charts. Don't think that will hurt anybody. Patching OFC is easy since it is now written in pure AS3 and the code structure is reasonably plausible.

I'll put the fork to svn/open-flash-charts/trunk if that's ok with you. Each commit will be commented so applying the patches to other forks should be easy.

@robocoder commented on August 3rd 2010 Contributor

Ok. (There's a post by etw that OFC trunk is buggy, so we should fork from the Lug Wyrm Charmer release.)

@gka commented on August 3rd 2010 Contributor

(In [2857]) updated tooltip appearance, party fixes #1545

@gka commented on August 3rd 2010 Contributor

(In [2858]) fixes #1545

  • updated tooltip colors
  • updated chart tooltips (setting values in bold text)
  • copied open-flash-chart.swf (OFC-patch #001)
  • copied PiwikMap.swf
@mattab commented on August 4th 2010 Member

simple yet great UI improvement :) good stuff Greg!

This Issue was closed on August 4th 2010
Powered by GitHub Issue Mirror