When closing a popover, leave opened any previously opened popover #15444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@sgiehl sounds like it is the ideal behavior now 👍 |
mattab
changed the title
mattab
added
the
c: Usability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating #15404 I discovered that the popover stack "feature" is kind of broken:
When opening popovers (segmented visitor log, visitor profile, ...) it is possible to open a popover from within another one. Those popovers are stored in a popover stack in javascript, to make it possible to open the previous popover if the current one is closed.
That is currently broken. When closing a popover it seems the stack is completely destroyed in any case.
With those changes the behaviour will be:
Clicking outside of the popover: complete stack will be closed
Clicking the close button (x): current popover will be closed, previous will be opened (if any)
Pressing Excape key: complete stack will be closed
Is that expected, or should that be changed some more?