@sgiehl opened this Pull Request on January 23rd 2020 Member

While investigating #15404 I discovered that the popover stack "feature" is kind of broken:

When opening popovers (segmented visitor log, visitor profile, ...) it is possible to open a popover from within another one. Those popovers are stored in a popover stack in javascript, to make it possible to open the previous popover if the current one is closed.
That is currently broken. When closing a popover it seems the stack is completely destroyed in any case.

With those changes the behaviour will be:

Clicking outside of the popover: complete stack will be closed
Clicking the close button (x): current popover will be closed, previous will be opened (if any)
Pressing Excape key: complete stack will be closed

Is that expected, or should that be changed some more?

@mattab commented on February 10th 2020 Member

Is that expected, or should that be changed some more?

@sgiehl sounds like it is the ideal behavior now :+1:

This Pull Request was closed on January 23rd 2020
Powered by GitHub Issue Mirror