Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in Visitors>User IDs, opening a Profile for a given User ID shouldn't show other visits from User IDs who shared the same computer #15440

Closed
mattab opened this issue Jan 23, 2020 · 13 comments
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Jan 23, 2020

Reproduce:

  • Go to Visitors>User IDs,
  • click the segmented visits log icon on a given User ID
  • the Visitor profile modal opens
  • Got: it shows the visits for a specific visitor ID. The URL looks like this for example. we clicked on the User ID momofdivers yet the URL includes visitorId$3Dd6ed99710191f9f5 instead of userId$3Dmomofdivers
  • Expected instead: it shows the visits where User ID is momofdivers

This has become a bigger issue after #14360 now that many User Ids visits can share the same visitor id.

Note: bug reported by on-premise customer.

It is important and expected to be able to see all visits for a given User ID directly using that icon.

Note: a workaround in the meantime is to create a Segment for each user ID and apply the segment to the Visits log.

@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Jan 23, 2020
@mattab mattab modified the milestones: 4.1.0, 4.2.0 Jan 23, 2020
@tsteur
Copy link
Member

tsteur commented Jan 23, 2020

This is not a bug. Visitor log always shows visitor log. What you are after would be a User profile basically.

@tsteur tsteur added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. and removed Bug For errors / faults / flaws / inconsistencies etc. labels Jan 23, 2020
@mattab
Copy link
Member Author

mattab commented Jan 23, 2020

  1. then we would need to remove the "User ID" from the visitor profile?

currently it shows the user ID: Screenshot from 2020-01-23 15-01-05

  1. also the "Open Visitor Profile" next to the User ID row, make people expect that they will see all visits for that visitor/user id. All other reports do this, when you click on the segmented visits log icon, it will segment with this dimension applied. But User ID is different. Maybe it's fine to leave it this way, but it's not quite clear.

@tsteur
Copy link
Member

tsteur commented Jan 23, 2020

Saying always Visitor Profile sounds good.

All other reports do this, when you click on the segmented visits log icon, it will segment with this dimension applied

In this case we are not showing the segmented visitor log, but the visitor profile. That's why it is expected to not be applied. Could also just show the segmented visitor log instead of the profile.

@mattab
Copy link
Member Author

mattab commented Jan 23, 2020

Saying always Visitor Profile sounds good.

👍

Could also just show the segmented visitor log instead of the profile.

That would work better imho 👍

@KarthikRaja1388
Copy link

same issue is raised again, viewing the segmented profile from "Visitors > user ID" is showing visits for one visitor id and ignoring the others

@mattab
Copy link
Member Author

mattab commented Feb 27, 2020

On a call now with a user, and he mentions how this is important.

There are 2 things to improve:

  • User ID report -> icon should open a User Profile showing all visits from this user id on all devices
  • Visits Log -> icon "View visitor profile" ideally be renamed to "View User USER_ID_HERE" for visits with a user id, and then when clicked it opens the User Profile showing all visits from this user id on all devices

@tsteur
Copy link
Member

tsteur commented Feb 27, 2020

@mattab what I'm reading here is to restore the old behaviour of user feature which refs #15593 . They could also simply like it was suggested for @peterbo try to set visitorId to same value as userId or generate it based on userId it might work.

From our side, if #15593 is not restored to the original behaviour, we will most likely show the segmented visitor log here

@mattab
Copy link
Member Author

mattab commented Mar 5, 2020

Let's wait for #15593 resolution. If we set Visitor id as a hash of User ID, then it would "solve" this issue as well.

@mattab
Copy link
Member Author

mattab commented Sep 24, 2020

Parts of the feature were re-added in https://github.com/matomo-org/matomo/pull/16226/files
but currently set to 0: enable_userid_overwrites_visitorid = 0
(the ini has no description and not documented yet in the website?)

-> would we consider set this to 1 by default in the future or in Matomo 4?

@tsteur
Copy link
Member

tsteur commented Sep 24, 2020

It is 1 in Matomo 4 already

@mattab
Copy link
Member Author

mattab commented Sep 24, 2020

Ok so this issue is likely already solved 👍
I'll test it as soon as I get 4.x-dev working (currently getting the Unknown column 'log_link_visit_action.time_network' in 'field list' )

@mattab mattab self-assigned this Sep 24, 2020
@mattab mattab added this to the 4.0.0 RC milestone Sep 24, 2020
@mattab
Copy link
Member Author

mattab commented Sep 24, 2020

Great news, it's now fixed in Matomo 4 🎉

@mattab mattab closed this as completed Sep 24, 2020
@mattab mattab removed their assignment Sep 24, 2020
@mattab mattab changed the title in Visitors>User IDs, opening a Profile using segmented visits log for a given User ID will also show other User IDs in Visitors>User IDs, opening a Profile for a given User ID will show other visits from User IDs who shared the same computer Sep 24, 2020
@mattab mattab changed the title in Visitors>User IDs, opening a Profile for a given User ID will show other visits from User IDs who shared the same computer in Visitors>User IDs, opening a Profile for a given User ID shouldn't show other visits from User IDs who shared the same computer Sep 24, 2020
@MatomoForumNotifications

This issue has been mentioned on Matomo forums. There might be relevant details there:

https://forum.matomo.org/t/some-user-visits-only-show-visitor-id/49516/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Development

No branches or pull requests

4 participants