Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No longer redirect when interacted with content #15406

Merged
merged 9 commits into from Feb 6, 2020
Merged

No longer redirect when interacted with content #15406

merged 9 commits into from Feb 6, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jan 16, 2020 •
edited

fix #6265
fix #12227

Will update minified JS once PR is approved.

We will also need to merge matomo-org/plugin-QueuedTracking#120

@tsteur tsteur added this to the 4.0.0 milestone Jan 16, 2020
@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels Jan 16, 2020
@tsteur tsteur mentioned this pull request Jan 16, 2020
Merged
@tsteur tsteur added Needs Review PRs that need a code review and removed Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels Jan 16, 2020
sgiehl
sgiehl requested changes Feb 4, 2020
View reviewed changes
js/piwik.js Show resolved Hide resolved
tests/PHPUnit/Integration/Tracker/RequestSetTest.php Show resolved Hide resolved
core/Tracker/RequestSet.php Show resolved Hide resolved
core/Tracker/RequestSet.php Show resolved Hide resolved
@tsteur
Copy link
Member Author

tsteur commented Feb 4, 2020

Cheers @sgiehl made the changes

@tsteur tsteur merged commit fd3e3d9 into 4.x-dev Feb 6, 2020
@tsteur tsteur deleted the 6265 branch February 6, 2020 19:06
@sgiehl sgiehl mentioned this pull request Aug 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0
2 participants
@tsteur @sgiehl