Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable send beacon by default #15405

Merged
merged 4 commits into from Jan 21, 2020
Merged

enable send beacon by default #15405

merged 4 commits into from Jan 21, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jan 16, 2020 •
edited

Will update minified JS once PR is approved

fix #13681

@tsteur tsteur added the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Jan 16, 2020
@tsteur tsteur added this to the 4.0.0 milestone Jan 16, 2020
@tsteur tsteur added Needs Review PRs that need a code review and removed Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels Jan 16, 2020
@sgiehl
Copy link
Member

sgiehl commented Jan 17, 2020

Do we need to mention that in the changelog or update some other related faqs or docs later?
Otherwise looks good to merge

@tsteur tsteur merged commit 61ed9e2 into 4.x-dev Jan 21, 2020
@tsteur tsteur deleted the defaultbeacon branch January 21, 2020 01:29
@tsteur
Copy link
Member Author

tsteur commented Jan 21, 2020

@sgiehl added changelog entry 👍

@sgiehl sgiehl mentioned this pull request Jan 25, 2020
Closed
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 29, 2020
@Findus23 Findus23 mentioned this pull request Dec 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

JS Tracker: enable alwaysUseSendBeacon by default
3 participants
@tsteur @sgiehl @mattab