@plegault3397 opened this Issue on January 16th 2020

I did upgrade to the new release Matomo 3.13.1
I have seen this before.
When opening the real time map and selecting one of the dots I can review the activity. When I click on the x in the top right corner nothing happens. I can click away from the box and it does close.

@tsteur commented on January 16th 2020 Member

Indeed this no longer works. It works as a workaround when clicking on the background.

@tsteur commented on January 23rd 2020 Member

This is actually not a regression. At least it's not working in 3.13 either and it doesn't look like this has been changed in a while. Will move it into 4.1 release.

The issue seems around https://github.com/matomo-org/matomo/blob/3.13.1/plugins/Live/javascripts/visitorProfile.js#L79

Quickly spent 15 min trying to fix it by adding code like this


                if (self.$element.closest('#Piwik_Popover').length) {
                    Piwik_Popover.close();
                }

but I think this could have side effects maybe. Then thought maybe


                if (self.$element.closest('#Piwik_Popover').length) {
                    self.$element.closest('#Piwik_Popover').dialog('close');
                }

is maybe a better solution but not sure if this would confuse the popover stack etc. Not sure what the best solution is there/

@sgiehl commented on January 23rd 2020 Member

@tsteur It's actually easy to fix. The problem is, that when opening the visitor profile from the map it's directly opened within the popover, without using the url hash. In that case a simple Piwik_Popover.close() works. But when the url hash is present (e.g. from visitor log), that shouldn't be done.
I'll prepare a quick fix for that. Will target 3.x-dev, let me know if that's fine. Otherwise I'll rebase it to target 4.x-dev instead.

@plegault3397 commented on January 23rd 2020

I just mentioned it as an information, it is not an issue for me to click around to close it out. It can wait for 4.x

From: Stefan Giehl <notifications@github.com>
Sent: Thursday, January 23, 2020 1:04 PM
To: matomo-org/matomo <matomo@noreply.github.com>
Cc: Legault, Phillip [GTSUS] <PLEGAULT@ITS.JNJ.COM>; Author <author@noreply.github.com>
Subject: [EXTERNAL] Re: [matomo-org/matomo] Real time map dialog box does not close with x (#15404)

@tsteurhttps://github.com/tsteur It's actually easy to fix. The problem is, that when opening the visitor profile from the map it's directly opened within the popover, without using the url hash. In that case a simple Piwik_Popover.close() works. But when the url hash is present (e.g. from visitor log), that shouldn't be done.
I'll prepare a quick fix for that. Will target 3.x-dev, let me know if that's fine. Otherwise I'll rebase it to target 4.x-dev instead.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/matomo-org/matomo/issues/15404?email_source=notifications&email_token=ABV66OZ7CMTCEA4LV5DSXI3Q7HLZ3A5CNFSM4KHUZGMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJYIJFI#issuecomment-577799317, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABV66O6IMR2IBIQGH2GGALDQ7HLZ3ANCNFSM4KHUZGMA.

This Issue was closed on January 24th 2020
Powered by GitHub Issue Mirror