Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release notes error: DB changes in 3.13.1 #15402

Closed
toredash opened this issue Jan 16, 2020 · 4 comments
Closed

Release notes error: DB changes in 3.13.1 #15402

toredash opened this issue Jan 16, 2020 · 4 comments
Labels
answered For when a question was asked and we referred to forum or answered it.

Comments

@toredash
Copy link
Contributor

toredash commented Jan 16, 2020 •
edited

In the changelog it says there isn't any major DB changes (https://matomo.org/changelog/matomo-3-13-1/)

But there is in fact some DB changes in commit https://github.com/matomo-org/matomo/blob/4ad9f4ac89e6cbdb7b7c50bed4155193eb762dcc/core/Updates/3.13.1-b2.php

This should be noted in the release note. AFAIK, one need to run ./path/to/matomo/console core:update to execute that specific SQL statement.

Is it correct that this information should be provided in the release notes ? I assume most users don't review commits from release to release.
@mattab
Copy link
Member

mattab commented Jan 16, 2020

This doesn't count as a "Major" db change as it only updates some fields. By Major we mean schema changes mostly (new columns, indexes, etc.)

@mattab mattab closed this as completed Jan 16, 2020
@mattab mattab added the answered For when a question was asked and we referred to forum or answered it. label Jan 16, 2020
@mattab
Copy link
Member

mattab commented Jan 16, 2020

To answer your question, the SQL will be automatically executed via the Web UI and there's nothing users have to do, so it should just work 👍

@tsteur
Copy link
Member

tsteur commented Jan 16, 2020

@mattab unless auto updates etc are disabled. Generally, core:update would always need to be executed when not updating through UI

@toredash
Copy link
Contributor Author

@mattab unless auto updates etc are disabled. Generally, core:update would always need to be executed when not updating through UI

We run stateless containers, and therefore don't use any of the auto update features or installing of plugins via the UI.

I'll just add a step to our routines to always run core:update when a new release is put into play, as thats probably easier than looking at each commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
answered For when a question was asked and we referred to forum or answered it.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tsteur @toredash @mattab