New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refs #3505 DevicesDetection plugin - provides detection of TVs #154
Conversation
Adding regex for ANTGalio and Opera Next
Adding Regular Expressions for most common TV Brands
Brand of Dreambox
+ Adding most common TV Brands + Adding ANTGalio Browser and ANT Browser familiy + Adding Opera Next Browser (Blink Engine) + Adding $televisionRegexesFile + Adding getTelevisionRegexes() + Adding parseTelevision() + Adding isTelevision() + Modify parse() + Modify parseBrand() + Modify parseModel()
+ Modify pseudo TVs to desktop devices (AppleTV, GoogleTV) + Removing real TVs (now they are in televisions.yml)
+ Cleanup unnecessary blank lines
+ Modify old icons + Adding new icons
+ Medion + Videoweb
+ Name / ShortName + Icon + Regex
Adding many televion UAs
remove double bracket
This is the 2nd try ... |
looks like a very good change to add TV detection! To prepare better I made some improvements in the test fixtures format: https://github.com/piwik/piwik/blob/master/tests/PHPUnit/Fixtures/userAgentParserEnhancedFixtures.yml with the new "device" category. In fact i'm thinking we should split the test fixture file in separate files per device type or so... Would you mind updating the PR to latest master? and see if Travis is green (it is now) Looking forward to include it in Piwik 👍 |
This update provides detecting TVs with the DevicesDetection plugin based on the UserAgent.
Testet with several devices (see picture attached):