Refs #3505 DevicesDetection plugin - provides detection of TVs #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding regex for ANTGalio and Opera Next
Adding Regular Expressions for most common TV Brands
Brand of Dreambox
+ Adding most common TV Brands + Adding ANTGalio Browser and ANT Browser familiy + Adding Opera Next Browser (Blink Engine) + Adding $televisionRegexesFile + Adding getTelevisionRegexes() + Adding parseTelevision() + Adding isTelevision() + Modify parse() + Modify parseBrand() + Modify parseModel()
+ Modify pseudo TVs to desktop devices (AppleTV, GoogleTV) + Removing real TVs (now they are in televisions.yml)
+ Cleanup unnecessary blank lines
+ Modify old icons + Adding new icons
+ Medion + Videoweb
+ Name / ShortName + Icon + Regex
Adding many televion UAs
remove double bracket
|
This is the 2nd try ... |
mattab
added a commit
that referenced
this pull request
Dec 8, 2013
|
looks like a very good change to add TV detection! To prepare better I made some improvements in the test fixtures format: https://github.com/piwik/piwik/blob/master/tests/PHPUnit/Fixtures/userAgentParserEnhancedFixtures.yml with the new "device" category. In fact i'm thinking we should split the test fixture file in separate files per device type or so... Would you mind updating the PR to latest master? and see if Travis is green (it is now) Looking forward to include it in Piwik 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update provides detecting TVs with the DevicesDetection plugin based on the UserAgent.
Testet with several devices (see picture attached):