Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LoginHttpAuth submodule #15396

Merged
merged 2 commits into from Jan 16, 2020
Merged

Remove LoginHttpAuth submodule #15396

merged 2 commits into from Jan 16, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jan 15, 2020

We decided we no longer support it in Matomo 4 for various reasons such as security and wanting to focus more on the essential things and being able to focus. I suppose we could create an issue on LoginHttpAuth if someone wanted to take over the project and continue supporting it? A few changes would need to be made to make it compatible with Matomo 4 because of #6559

@tsteur tsteur added the Needs Review PRs that need a code review label Jan 15, 2020
@tsteur tsteur added this to the 4.0.0 milestone Jan 15, 2020
@sgiehl
Copy link
Member

sgiehl commented Jan 15, 2020

Guess that line can be removed as well then:

$disabledPlugins[] = 'LoginHttpAuth';

@tsteur
Copy link
Member Author

tsteur commented Jan 15, 2020

👍 made that change

@sgiehl sgiehl merged commit abd7d9d into 4.x-dev Jan 16, 2020
@sgiehl sgiehl deleted the removeloginhttpauth branch January 16, 2020 16:33
@mattab mattab added the Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. label Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants