Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes some methods deprecated for Matomo 4 #15386

Merged
merged 3 commits into from Jan 16, 2020
Merged

Removes some methods deprecated for Matomo 4 #15386

merged 3 commits into from Jan 16, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jan 13, 2020 •
edited

  • Removes deprecated Plugin.getListHooksRegistered and uses Plugin.registerEvents instead
  • Removes deprecated method Piwik\Piwik::doAsSuperUser
  • Removes deprecated SettingsPiwik::isPiwikInstalled and use SettingsPiwik::isMatomoInstalled instead

@sgiehl sgiehl added the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Jan 13, 2020
@sgiehl sgiehl added this to the 4.0.0 milestone Jan 13, 2020
@sgiehl sgiehl changed the title Removes methods deprecated for Matomo 4 Removes some methods deprecated for Matomo 4 Jan 15, 2020
@sgiehl sgiehl added Needs Review PRs that need a code review and removed Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels Jan 15, 2020
@sgiehl sgiehl marked this pull request as ready for review January 15, 2020 17:06
@tsteur tsteur merged commit 7c059ec into 4.x-dev Jan 16, 2020
@tsteur tsteur deleted the removedeprecations branch January 16, 2020 00:26
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sgiehl @tsteur @mattab