Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String not loaded in javascript while Feedback plugin is disabled #15385

Closed
tassoman opened this issue Jan 13, 2020 · 1 comment · Fixed by #16460
Closed

String not loaded in javascript while Feedback plugin is disabled #15385

tassoman opened this issue Jan 13, 2020 · 1 comment · Fixed by #16460
Labels
Bug For errors / faults / flaws / inconsistencies etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Milestone
4.1.0

Comments

@tassoman
Copy link
Contributor

I've disabled Feedback core plugin, when I try searching websites in the upper left box, Matomo can't load translation string about SearchOnMatomo.

Screenshot_2020-01-13 All Websites dashboard - 2020-01-13 - Web Analytics Reports - Matomo

Should be hidden the whole Help Resources section if the plugin is disabled? Or should the translation string reside in another plugin? Can't say 🤔
@tsteur tsteur added Bug For errors / faults / flaws / inconsistencies etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. labels Jan 13, 2020
@tsteur
Copy link
Member

tsteur commented Jan 13, 2020

It should be in the CoreHome plugin indeed 👍

@tsteur tsteur added this to the 4.1.0 milestone Jan 13, 2020
@nina-py nina-py mentioned this issue Sep 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Projects
None yet
Milestone
4.1.0
Development

Successfully merging a pull request may close this issue.

Moved search translation string from the Feedback plugin to the CoreHome one
2 participants
@tassoman @tsteur