@cundd opened this Pull Request on January 10th 2020 Contributor

This PR uses the configCookiePath, configCookieDomain and configCookieIsSecure configurations when the test-cookie is set.

@cundd commented on January 10th 2020 Contributor

Unfortunately I wasn't able to correctly preform the UI test suites. Are there tests for the tracking JS that need to pass/I need to modify to make the tests pass?

@tsteur commented on January 12th 2020 Member

Cheers @cundd the JS tests are parsing. You can execute them by opening https://yourMatomodomain.com/tests/javascript.

There were some integration tests failing as it is currently checking to not have an empty line at the end for some reason so tweaked it. Will merge it soon.

Tested it and worked 👍

This Pull Request was closed on January 12th 2020
Powered by GitHub Issue Mirror